Skip to content

bpo-41497: Fix potential UnicodeDecodeError in dis#21757

Merged
methane merged 2 commits into
python:masterfrom
zkonge:zkonge/fix_dis_encoding
Aug 8, 2020
Merged

bpo-41497: Fix potential UnicodeDecodeError in dis#21757
methane merged 2 commits into
python:masterfrom
zkonge:zkonge/fix_dis_encoding

Conversation

@zkonge

@zkonge zkonge commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

@methane

methane commented Aug 7, 2020

Copy link
Copy Markdown
Member

Would you add a news entry?

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM.

Please add a NEWS entry.

@zkonge

zkonge commented Aug 7, 2020

Copy link
Copy Markdown
Contributor Author

NEWS added.

@methane methane merged commit a4084b9 into python:master Aug 8, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @zkonge for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2020
(cherry picked from commit a4084b9)

Co-authored-by: Konge <zkonge@outlook.com>
@bedevere-bot

Copy link
Copy Markdown

GH-21782 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2020
(cherry picked from commit a4084b9)

Co-authored-by: Konge <zkonge@outlook.com>
@bedevere-bot

Copy link
Copy Markdown

GH-21783 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Aug 8, 2020
(cherry picked from commit a4084b9)

Co-authored-by: Konge <zkonge@outlook.com>
miss-islington added a commit that referenced this pull request Aug 8, 2020
(cherry picked from commit a4084b9)

Co-authored-by: Konge <zkonge@outlook.com>
@zkonge zkonge deleted the zkonge/fix_dis_encoding branch August 8, 2020 11:45
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants